Make ResourceValidationHelper use AipiService if wanted - #1120
Open
Toastbrot236 wants to merge 7 commits into
Open
Make ResourceValidationHelper use AipiService if wanted#1120Toastbrot236 wants to merge 7 commits into
Toastbrot236 wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup PR which makes
ResourceValidationHelperactually useAipiServiceif it's provided as a parameter and the validated asset is an image. It also fixes a bug whereGameAssets auto-imported byResourceValidationHelperwere not being added to the database.Additionally, this also marks the
AipiServiceparameter on various endpoint methods as nullable to suppress useless warnings incase AIPI integration is disabled, and also suppresses a similar warning forResourceEndpoints.UploadAsset()'styperoute parameter, since it will be missing from ~99% of all game requests.This PR doesn't introduce any AIPI-related unit tests because that is blocked by #1118.