fix: redact logging of sensitive config & CSRF validation#4955
fix: redact logging of sensitive config & CSRF validation#4955psyke83 wants to merge 3 commits intoLizardByte:masterfrom
Conversation
|
If we're going to do this, can you add some basic regex validation to the allowed origins options so if it's not properly formatted it will at least log an error/warning. I think we basically only need to check that it starts with |
34a366a to
d7f0fa9
Compare
d7f0fa9 to
fd5db54
Compare
* Currently redacts csrf_allowed_origins. * Add simple validation of CSRF entries to ensure they are prefixed with 'https://'. * Individual invalid CSRF entries will be logged unredacted to assist troubleshooting.
fd5db54 to
8b4cf78
Compare
|
Ready for review. I would say that the remaining SonarQube errors can be disregarded, as I'm following the established signature of apply_config's It currently is only doing CSRF validation on the basis that the string is >8 chars and starts with 'https://'. |
Bundle ReportBundle size has no change ✅ |
|




with 'https://'.
troubleshooting.
Description
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage