screenshots: use subdirectories for the date and include the title ID#1488
screenshots: use subdirectories for the date and include the title ID#1488ioistired wants to merge 5 commits intoLumaTeam:masterfrom
Conversation
Using subdirectories allows for easier retrieval over FTP, as it reduces the amount of entries in the screenshots directory. Including the title ID lets users search for all screenshots they have of a certain game, or organize their screenshots by software instead of by date.
|
|
||
| FS_ProgramInfo programInfo; | ||
| u32 unused; | ||
| res = PMDBG_GetCurrentAppInfo(&programInfo, &unused, &unused); |
There was a problem hiding this comment.
I just realized there's a bug in this approach: screenshots taken of the home menu while software is suspended, and screenshots taken of applets while software is suspended, will result in the wrong title ID written. Is that an issue?
|
add location too? like if i have boot.firm on ctrnand it will make SS in nand not sd card we need a setting to chose SS location |
|
That's beyond the scope of this pull request. The original code saves to SD. |
Nope it does as I stated |
|
Oh I misread you. What part of my changes breaks the current behavior? |
| #define WRITE_SCREENSHOT(screenName, screenWidth, top, left) do { \ | ||
| sprintf( \ | ||
| filename, \ | ||
| "%s/%04lu-%02lu-%02lu_%02lu-%02lu-%02lu.%03llu_%016llx_%s.bmp", \ |
There was a problem hiding this comment.
Checkpoint uses the lower 4 bytes (8 nybbles) of the program's title ID. Should I do the same here?
|
@Shadow322 I tested it on NAND and it does indeed save to ctr:/rw/luma/screenshots/yyyy/mm/dd/ when the SD card is unavailable. I think a user-configurable toggle to choose where to save is beyond the scope of this pull request. You'll notice this line is unchanged from the original code: Luma3DS/sysmodules/rosalina/source/menus.c Line 358 in 89a872e |
TuxSH
force-pushed
the
master
branch
2 times, most recently
from
33fbfb3 to
35a7ca2
Compare
2 participants
Using subdirectories allows for easier retrieval over FTP,
as it reduces the amount of entries in the screenshots directory.
Including the title ID lets users search for all screenshots they have of a
certain game, or organize their screenshots by software instead of by date.