Skip to content

rosalina: add date and clock in top right corner #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MininuxDev wants to merge 9 commits into
base: master
Choose a base branch
from
Open

rosalina: add date and clock in top right corner #2223

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9045643
rosalina: add date and clock in top right corner
MininuxDev Mar 1, 2026
ac819b4
rosalina: remove unnecessary include
MininuxDev Mar 1, 2026
454bc59
rosalina: add padding to clock and ip
MininuxDev Mar 1, 2026
e7f3db8
rosalina: add human redable format to dateTimeToString
MininuxDev Mar 2, 2026
9ba0808
rosalina: add option to toggle clock display
MininuxDev Mar 5, 2026
71f575a
rosalina: remove forgotten code to toggle clock
MininuxDev Mar 5, 2026
37f5477
rosalina: revert togglable clock
MininuxDev Mar 22, 2026
7d8a563
rosalina: optimize dateTimeToString with loop-less version
MininuxDev Mar 25, 2026
d0fa5df
rosalina: remove previous commit wrong changes
MininuxDev Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sysmodules/rosalina/source/menu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,9 +475,13 @@ static void menuDraw(Menu *menu, u32 selected)
int n = sprintf(ipBuffer, "%hhu.%hhu.%hhu.%hhu", addr[0], addr[1], addr[2], addr[3]);
Draw_DrawString(SCREEN_BOT_WIDTH - 10 - SPACING_X * n, 10, COLOR_WHITE, ipBuffer);

This comment was marked as duplicate.

Sign in to view

Copy link
Copy Markdown
Member

@TuxSH TuxSH Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below

}

else
Draw_DrawFormattedString(SCREEN_BOT_WIDTH - 10 - SPACING_X * 15, 10, COLOR_WHITE, "%15s", "");
{
char buf[32];
u64 timeNow = osGetTime();
int n = dateTimeToString(buf, timeNow, false);
Copy link
Copy Markdown
Member

@TuxSH TuxSH Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using the ISO format used for screenshots, could you use this format: Wed, 31 Dec 2025 23:59. It is more readable and match what I'm using in a side project I'll soon integrate into Luma3DS.

Copy link
Copy Markdown
Author

@MininuxDev MininuxDev Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the dateTimeToString function to accept an enum parameter dateTimeFormat to select the format, including the human readable format (and thus adjusted the calls to the function in other places)

I could move the human readable formatter to another function if necessary.

Draw_DrawString(SCREEN_BOT_WIDTH - 10 - SPACING_X * n, 10, COLOR_WHITE, buf);

This comment was marked as duplicate.

Sign in to view

Copy link
Copy Markdown
Member

@TuxSH TuxSH Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ensure both the date string and the IP string are the same length, padding them with spaces as necessary? They aren't always cleared automatically.

Copy link
Copy Markdown
Author

@MininuxDev MininuxDev Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added space padding using a "%23s" format, if this is what you had in mind. Unless you meant manually drawing spaces ?

}

if(mcuInfoRes == 0)
{
Expand Down