feat: add unpin all subcommand with safety guards#39
Merged
Conversation
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Coverage ReportTotal Coverage: 33.9% Generated from commit: a276c9a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
unpin allsubcommand with safety guards for bulk pin removalThis PR introduces the
pinner unpin allsubcommand, which allows users to remove all pins (optionally filtered by status) in a single operation. Given the destructive nature of this action, multiple safety guards are implemented:--confirmflag required: The command will not execute without explicitly passing--confirmto acknowledge the destructive operation.--yesflag for non-interactive use: In scripts or CI environments,--yesskips the interactive prompt (but--confirmremains required).--dry-runsupport: Preview which pins would be removed without actually unpinning them.--statusfilter: Optionally target only pins with a specific status (e.g.,--status failedto unpin only failed pins).--paralleland--continueflags for controlling concurrency and error handling.Key changes:
UnpinAllmethod added to thePinningServiceinterface and implemented inPinningServiceDefault(lists pins, extracts CIDs, delegates toUnpinBatch)ErrUnpinAllAbortederror type for when the safety prompt is cancelled--yesflag constant (FlagYes)unpincommand description and registeredallas a subcommand