feat: verify pin in pinning API after account operation completes with --wait#41
Merged
Merged
Conversation
…h --wait When --wait is used with upload, the CLI now waits for the account operation to complete, then verifies the pin is visible in the pinning API with a pinned status. Uses retry with backoff (10 attempts, 2-30s) to handle propagation delay between the account operation finishing and the pin appearing in the pinning service. Failures are now hard errors instead of warnings.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
Code Coverage ReportTotal Coverage: 34.4% Generated from commit: 5a9cd70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --wait is used with upload, the CLI now waits for the account
operation to complete, then verifies the pin is visible in the pinning
API with a pinned status. Uses retry with backoff (10 attempts, 2-30s)
to handle propagation delay between the account operation finishing and
the pin appearing in the pinning service. Failures are now hard errors
instead of warnings.
Add pin verification via pinning API after account operation completes when using
--waitWhen the
--waitflag is used during upload, the CLI now verifies that the pin actually exists and reaches "pinned" status in the pinning API after the account operation completes. Previously,--waitonly waited for the account operation to finish without confirming the pin was fully established. The verification uses retry logic (up to 10 attempts with exponential backoff) to poll the pinning service status. Additionally, errors during the wait-for-pin process are now returned as errors instead of being silently logged as warnings.