feat(cli): expand test coverage, unify quota delegation, improve docs#75
Merged
Conversation
- Add behavioral tests across all CLI commands covering service calls, parameter handling, auth gates, and error paths - Add delegation error-path and profiling tests for admin service - Unify quota admin methods with generic helpers (with2/with3/with0/with2i), reducing admin_service.go boilerplate - Extract commandGetter interface and shared mockCommand for consistent test patterns across handlers - Extract prompt interfaces (Prompt/Confirm/Select) from handlers into testable abstractions - Add Makefile with git-based ldflags (version, commit, branch, build time, platform) replacing hardcoded build info - Reorder install docs: releases → go install → go build - Fix README alias framing: "not deprecated" → "first-class shortcuts"
Code Coverage ReportTotal Coverage: 52.8% Generated from commit: 3c53fd8 |
This comment has been minimized.
This comment has been minimized.
- Add s.service nil guards to ipnsService and websitesService methods, preventing panics when ipfs.NewClient() fails (matching dnsServiceCLI) - Propagate --secure flag through newAuthenticated*Service constructors for DNS, Websites, and IPNS services - Pass secure bool to unpin, unpinAll, status, and download handlers - Use GetIPFSEndpointWithSecure(secure) instead of GetIPFSEndpoint() or GetIPFSEndpointSecure() in all handler and factory code - Fix dry-run displays to respect the secure flag - Update PinningServiceFactory and all callers to accept secure bool
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calls, parameter handling, auth gates, and error paths
(with2/with3/with0/with2i), reducing admin_service.go boilerplate
consistent test patterns across handlers
into testable abstractions
build time, platform) replacing hardcoded build info