Skip to content

feat(cli): expand test coverage, unify quota delegation, improve docs#75

Merged
pcfreak30 merged 2 commits into
developfrom
feat/test-coverage-delegation-docs
Jun 11, 2026
Merged

feat(cli): expand test coverage, unify quota delegation, improve docs#75
pcfreak30 merged 2 commits into
developfrom
feat/test-coverage-delegation-docs

Conversation

@pcfreak30

Copy link
Copy Markdown
Member
  • Add behavioral tests across all CLI commands covering service
    calls, parameter handling, auth gates, and error paths
  • Add delegation error-path and profiling tests for admin service
  • Unify quota admin methods with generic helpers
    (with2/with3/with0/with2i), reducing admin_service.go boilerplate
  • Extract commandGetter interface and shared mockCommand for
    consistent test patterns across handlers
  • Extract prompt interfaces (Prompt/Confirm/Select) from handlers
    into testable abstractions
  • Add Makefile with git-based ldflags (version, commit, branch,
    build time, platform) replacing hardcoded build info
  • Reorder install docs: releases → go install → go build
  • Fix README alias framing: "not deprecated" → "first-class shortcuts"

- Add behavioral tests across all CLI commands covering service
  calls, parameter handling, auth gates, and error paths
- Add delegation error-path and profiling tests for admin service
- Unify quota admin methods with generic helpers
  (with2/with3/with0/with2i), reducing admin_service.go boilerplate
- Extract commandGetter interface and shared mockCommand for
  consistent test patterns across handlers
- Extract prompt interfaces (Prompt/Confirm/Select) from handlers
  into testable abstractions
- Add Makefile with git-based ldflags (version, commit, branch,
  build time, platform) replacing hardcoded build info
- Reorder install docs: releases → go install → go build
- Fix README alias framing: "not deprecated" → "first-class shortcuts"
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

Code Coverage Report

Total Coverage: 52.8%

Generated from commit: 3c53fd8
Repository: LumeWeb/pinner-cli

@kody-ai

This comment has been minimized.

Comment thread pkg/cli/dns_service.go Outdated
Comment thread pkg/cli/ipns_service.go
Comment thread pkg/cli/unpin.go
Comment thread pkg/cli/websites.go

@kody-ai kody-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Add s.service nil guards to ipnsService and websitesService methods,
  preventing panics when ipfs.NewClient() fails (matching dnsServiceCLI)
- Propagate --secure flag through newAuthenticated*Service constructors
  for DNS, Websites, and IPNS services
- Pass secure bool to unpin, unpinAll, status, and download handlers
- Use GetIPFSEndpointWithSecure(secure) instead of GetIPFSEndpoint()
  or GetIPFSEndpointSecure() in all handler and factory code
- Fix dry-run displays to respect the secure flag
- Update PinningServiceFactory and all callers to accept secure bool
@kody-ai

kody-ai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@pcfreak30 pcfreak30 merged commit c7bddd4 into develop Jun 11, 2026
2 checks passed
@pcfreak30 pcfreak30 deleted the feat/test-coverage-delegation-docs branch June 11, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant