Skip to content

fix: use GreaterOrEqual for duration assertion in PinBatch test#80

Merged
pcfreak30 merged 1 commit into
developfrom
fix/windows-zero-duration-assert
Jun 11, 2026
Merged

fix: use GreaterOrEqual for duration assertion in PinBatch test#80
pcfreak30 merged 1 commit into
developfrom
fix/windows-zero-duration-assert

Conversation

@pcfreak30

@pcfreak30 pcfreak30 commented Jun 11, 2026

Copy link
Copy Markdown
Member

Mocked operations can execute in 0s on Windows.


This pull request fixes a flaky test in the PinBatch test suite by changing the duration assertion from Greater to GreaterOrEqual. On Windows, the execution can be fast enough to result in a zero duration, which caused the previous strict "greater than zero" assertion to fail. Allowing a zero duration resolves this test failure on Windows.

Mocked operations can execute in 0s on Windows.
@kody-ai

kody-ai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@github-actions

Copy link
Copy Markdown

Code Coverage Report

Total Coverage: 53.5%

Generated from commit: db31169
Repository: LumeWeb/pinner-cli

@pcfreak30 pcfreak30 merged commit 5ffb1c3 into develop Jun 11, 2026
9 checks passed
@pcfreak30 pcfreak30 deleted the fix/windows-zero-duration-assert branch June 11, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant