fix: Correct component instantiation level for thread safety - #274
Merged
Conversation
Changed InvalidateOnSettingsChange component instantiation level from DemandAnyThreadSafe to ContainerAsyncPrimaryThread to match the thread safety level of its RiderDaemonImpl dependency. This resolves the plugin installation error: "Component CleanCode.InvalidateOnSettingsChange is DeadlockSafe (DemandAnyThreadSafe), but it requires JetBrains.Rider.Backend.Features.Daemon.RiderDaemonImpl which is not DeadlockSafe" Components with different thread safety requirements were causing deadlock issues during plugin initialization.
MO2k4
force-pushed
the
fix/plugin-install-finding
branch
from
July 17, 2025 08:30
85a71f4 to
f65c999
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed InvalidateOnSettingsChange component instantiation level from DemandAnyThreadSafe to ContainerAsyncPrimaryThread to match the thread safety level of its RiderDaemonImpl dependency.
This resolves the plugin installation error:
"Component CleanCode.InvalidateOnSettingsChange is DeadlockSafe (DemandAnyThreadSafe), but it requires JetBrains.Rider.Backend.Features.Daemon.RiderDaemonImpl which is not DeadlockSafe"
Components with different thread safety requirements were causing deadlock issues during plugin initialization.