Skip to content

Préavis - Mention correctif dans notifications#4982

Draft
n0izn0iz wants to merge 3 commits intonorman/preavis-zero-mentionfrom
norman/preavis-notif-mention-cor
Draft

Préavis - Mention correctif dans notifications#4982
n0izn0iz wants to merge 3 commits intonorman/preavis-zero-mentionfrom
norman/preavis-notif-mention-cor

Conversation

@n0izn0iz
Copy link
Copy Markdown
Collaborator

@n0izn0iz n0izn0iz commented Apr 6, 2026

Fixes #3725
Depends on #4981

WIP

J'ai quelques doutes:

Il semble que les tables manual_prior_notifications et logbook_reports sont utilisées pour générer des PNO (fichier pipeline/src/queries/monitorfish/pnos_to_generate.sql) et qu'elles manques certaines data pour match l'ui dans cette issue.

  • J'ai pas l'impression que la notion de correctif existe pour la table manual_prior_notifications, pas sur de comment procéder, ajouter un champ modified_at?
  • Pour la table logbook_reports, le champ operation_type est set a la valeur COR mais il n'y a pas de date de correction apparente. Pas sur de comment procéder aussi.

@tristanrobert
Copy link
Copy Markdown

tristanrobert commented Apr 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@n0izn0iz n0izn0iz self-assigned this Apr 6, 2026
@n0izn0iz n0izn0iz force-pushed the norman/preavis-notif-mention-cor branch 2 times, most recently from e0d8872 to 7da0fa1 Compare April 28, 2026 12:11
@n0izn0iz n0izn0iz changed the base branch from master to norman/preavis-zero-mention April 28, 2026 12:14
@n0izn0iz n0izn0iz force-pushed the norman/preavis-zero-mention branch 2 times, most recently from 5fc2cfc to b5a7352 Compare April 29, 2026 16:47
@n0izn0iz n0izn0iz force-pushed the norman/preavis-notif-mention-cor branch from 17a102d to 2ebf053 Compare April 29, 2026 16:54
Signed-off-by: Norman <7917064+n0izn0iz@users.noreply.github.com>
@n0izn0iz n0izn0iz force-pushed the norman/preavis-notif-mention-cor branch from 2ebf053 to 9ab13ba Compare April 30, 2026 09:49
Signed-off-by: Norman <7917064+n0izn0iz@users.noreply.github.com>
Signed-off-by: Norman <7917064+n0izn0iz@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Préavis – Dans le cas de corrections d'un préavis (manuel et auto), ajouter une mention dans la diffusion

2 participants