fix lift from fraction field to base/coefficient ring (#3896)#4270
Open
pzinn wants to merge 1 commit into
Open
fix lift from fraction field to base/coefficient ring (#3896)#4270pzinn wants to merge 1 commit into
pzinn wants to merge 1 commit into
Conversation
Contributor
Author
|
this is ready to be merged |
Member
|
Will it conflict with the monster engine PR? |
Contributor
Author
|
how would I know? I submitted this before any of this |
Member
|
I just meant is it changing the same files as that PR? It's okay if you don't know, it's a reminder for whoever is going to merge to check first. |
Member
|
Pretty much every file in the engine is getting moved :) I think the plan is to merge the "great sort" PR first (#4347) and then rebase the others (including this one) after that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FractionField::lift was gated on R_->is_field(), which is always false for the polynomial ring underlying a fraction field. Replace the guard with R_->is_unit(h->denom), and chain through R_->lift so e.g. lift(1/123_(frac QQ[x]), QQ) also works.
AI Disclosure
Claude Code helped me write this.