Refactoring from Atlanta conference#4346
Conversation
…ine development work.
RingElem wraps (Ring*, ring_elem) with stack allocation and value-returning operators, replacing verbose RingElement pointer code in tests. Includes fromString via BasicPolyListParser. Also adds Monoid::variableNames(). I am using claude code opus 4.6 to help do this, in part to learn how to use claude effectively.
…g camel case instead of snake case for method names
…imple QuotientRingTest
Mburr group4 sagbi.hpp
fix IM2 in matrix.h/.cpp
First commit of a file that Mike gave us
Changed comments in NAG to use doxygen style
Turned IM2 names to raw
…cing Matrix::promote
Push down 2/6 heavy-logic functions in interface/matrix.cpp to engine e/
Interface refactors
set JAVADOC_AUTBRIEF to YES
Clean up matrix.cpp in interface/
| F->append(deg); | ||
| } | ||
| return F; | ||
| return R->make_FreeModule(degs->len, degs->array); |
There was a problem hiding this comment.
I really like these simplifications in the interface directory, by the way!
| Build configurations are defined in `M2/BUILD/mike/Makefile`. Existing builds live | ||
| under `M2/BUILD/mike/builds.tmp/`. |
There was a problem hiding this comment.
I think either this CLAUDE.md file should be in M2/BUILD/mike or if it's in the repository root it should be usable to others.
There was a problem hiding this comment.
Looking at the blame, this seems to be from @mikestillman from 3 months ago. Mike, can you comment on these lines?
| - **FFLAS_FFPACK** (2.4.3+) - Finite field linear algebra routines (needs LAPACK, GIVARO) | ||
| - **GIVARO** (4.1.1+) - Prime field and algebraic computations | ||
|
|
||
| ### Libraries (found via find_package / FindXxx.cmake) |
There was a problem hiding this comment.
I'm not sure what's the source of this list, but it seems very incomplete (e.g. tbb and boost are missing). Perhaps we could just write that the list of dependencies should be read from cmake/check-libraries.cmake?
There was a problem hiding this comment.
I agree that it would be best for this to be a complete list or to not have the list at all. I believe that this also comes from @mikestillman .
mahrud
left a comment
mahrud
left a comment
There was a problem hiding this comment.
I did a brief review. Pretty much everything looks good.
- I tried rebasing to see if getting rid of the merge commits to linearize the history would be easy, sadly didn't seem so.
- I think CLAUDE.md should either be elsewhere or be applicable generally. Currently Mike's build process is hardcoded into it.
- I suspect the error failing indicates a behavior change or revealed bug, but I couldn't find it. Here's the message:
-- error log: /home/runner/work/M2/M2/M2/BUILD/build/usr-dist/common/share/doc/Macaulay2/ToricVectorBundles/example-output/_is__Vector__Bundle.errors:0:1:(3):[14]:
stdio:6:14:(3):[1]: error: first error occurred while lifting matrix entry at row 1, column 0
|
Also, could you edit the top message to elaborate on AI use in this PR? |
|
@mahrud I agree that this ToricVectorBundles error may be new behavior. I'll start a bisect to try to find it. |
|
@mikestillman @andrew-tawfeek Could you add an AI statement to the pull request recording to what extent AI was used? |
11 participants
These are the changes from the Macaulay2 conference C/C++ refactoring group. This focuses on documentation, unit tests, and changes to the interface directory.