Install Bertini in GitHub workflows#4369
Draft
d-torrance wants to merge 3 commits into
Draft
Conversation
* clang-16 and libomp-16-dev are unused (plug clang-16 is already installed) * libncurses5-dev is provided by libncurses-dev, which already exists on the GitHub runners * libxml2-dev and gfortran are already installed on the GitHub runners * w3c-markup-validator was for the old xhtml-based validation foo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, we can properly test packages that use it (e.g., #4353). The download should be cached so we don't overload the Notre Dame servers.
I also took the opportunity to simplify the
apt-get installstep a bit -- there were a few packages we aren't using or are already installed on the GitHub Ubuntu runners.Partially addresses #1955
Draft for now, as the tests will fail until #4368 is fixed.
AI Disclosure
Claude Code wrote the code to download and cache Bertini.