Skip to content

fix round change when collatorset is empty + log in runtime#1128

Merged
Garandor merged 3 commits into
mantafrom
fix_nimbus_round_change
May 30, 2023
Merged

fix round change when collatorset is empty + log in runtime#1128
Garandor merged 3 commits into
mantafrom
fix_nimbus_round_change

Conversation

@Garandor
Copy link
Copy Markdown
Contributor

@Garandor Garandor commented May 28, 2023

Description

see https://substrate.stackexchange.com/questions/7835/logging-best-practice-for-pallet-extrinsics/8126#8126


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added C-bug Category: Issues documenting a bug A-calamari Area: Issues and PRs related to the Calamari Runtime A-automation Area: Issues and PRs related to Automation L-fixed Log: Issues and PRs related to bug fixes labels May 28, 2023
@Garandor Garandor self-assigned this May 28, 2023
@Garandor Garandor changed the title fix round change when collatorset is empty fix round change when collatorset is empty + log in runtime May 28, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

Comment thread pallets/parachain-staking/src/lib.rs
@Garandor Garandor merged commit c71b65d into manta May 30, 2023
@Garandor Garandor deleted the fix_nimbus_round_change branch May 30, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-automation Area: Issues and PRs related to Automation A-calamari Area: Issues and PRs related to the Calamari Runtime C-bug Category: Issues documenting a bug L-fixed Log: Issues and PRs related to bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants