TICKET-647: Fix unselected output verbosity in py test groups - #748
Open
Naragod wants to merge 1 commit into
Open
TICKET-647: Fix unselected output verbosity in py test groups#748Naragod wants to merge 1 commit into
Naragod wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Saving autotest settings fails for Python test groups. The form shows two errors on the group:
must be equal to one of the allowed valuesunder Output verbositymust match exactly one schema in oneOfon the group as a wholePyTestDatasetsoutput_verbosityto""at runtime.generate_schemacopies that sentinel into the JSON Schema asdefault, so the form seeds the field with""before thetesterdependency picks a branch. The pytest branch acceptsshort,auto,long,no,line, andnative. The unittest branch accepts0,1, and2. Neither lists"". The field breaks its own enum, and the group then matches neither branch, which raises theoneOferror.Implementation
defaultforoutput_verbosityinserver/autotest_server/testers/py/setup.pysuch that the form seeds the field from the matched branch instead.shortfor pytest,2for unittest.Note
Fixes MarkUs issue 8129.