Skip to content

Fix: MML #1531 Enable Large Support and Superheavy Location Tables in Record Sheets - #2245

Draft
WellBattle6 wants to merge 3 commits into
MegaMek:mainfrom
WellBattle6:addLargeSupportAndSuperheavyLocationTables
Draft

Fix: MML #1531 Enable Large Support and Superheavy Location Tables in Record Sheets#2245
WellBattle6 wants to merge 3 commits into
MegaMek:mainfrom
WellBattle6:addLargeSupportAndSuperheavyLocationTables

Conversation

@WellBattle6

@WellBattle6 WellBattle6 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Fix MML #1531

Note to reviewer: MERGE AFTER MMD side PR MegaMek/mm-data#447

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates composite vehicle record sheet table selection so the “tables” half of the composite sheet can show the appropriate hit-location/reference tables for Large Support Vehicles and Superheavy vehicles (including TacOps Vehicle Effectiveness variants).

Changes:

  • Selects Large Support Vehicle-specific table templates when tank1 is a Large support vehicle.
  • Selects Superheavy-specific table templates when tank1 is superheavy.
  • Preserves the existing TacOps Vehicle Effectiveness template selection behavior across all cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread megameklab/src/megameklab/printing/PrintCompositeTankSheet.java Outdated
Comment thread megameklab/src/megameklab/printing/PrintCompositeTankSheet.java Outdated
Comment thread megameklab/src/megameklab/printing/PrintCompositeTankSheet.java Outdated
@WellBattle6
WellBattle6 force-pushed the addLargeSupportAndSuperheavyLocationTables branch from 274d58e to 8912887 Compare July 13, 2026 16:06
@WellBattle6
WellBattle6 force-pushed the addLargeSupportAndSuperheavyLocationTables branch 2 times, most recently from 95542bc to c525c9a Compare August 1, 2026 21:28
@WellBattle6
WellBattle6 force-pushed the addLargeSupportAndSuperheavyLocationTables branch from c525c9a to 2723bbb Compare August 11, 2026 15:24
@IllianiBird
IllianiBird marked this pull request as draft September 5, 2026 14:52
@IllianiBird

Copy link
Copy Markdown
Collaborator

Converted to draft so this cannot be accidentally merged. Last update I'm aware of is that we're waiting on an official ruling.

@WellBattle6
WellBattle6 force-pushed the addLargeSupportAndSuperheavyLocationTables branch from 8ca4311 to 02ad267 Compare September 5, 2026 21:37
@WellBattle6
WellBattle6 marked this pull request as ready for review September 8, 2026 15:33
@WellBattle6
WellBattle6 marked this pull request as draft September 8, 2026 15:33
@WellBattle6 WellBattle6 closed this Sep 8, 2026
@WellBattle6 WellBattle6 reopened this Sep 8, 2026
@WellBattle6
WellBattle6 force-pushed the addLargeSupportAndSuperheavyLocationTables branch from 02ad267 to 821e733 Compare September 9, 2026 00:26
@WellBattle6
WellBattle6 force-pushed the addLargeSupportAndSuperheavyLocationTables branch from 821e733 to c28a6c2 Compare September 9, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants