Default skill progression values are not correct

[AlexOldenburger]

What went wrong

When starting a new campaign, the default skill XP costs are not as they should be.

Some skills use the new (more expensive) costs, while others use the older ones.

Note, it could very well be that this issue relates to MM-data, rather than MekHQ.

What you expected instead

The new default skill XP costs should be used when starting a new campaign.

Steps to reproduce

Start a new campaign
Accept all default values for the difficulty setting (tried with several settings)
Open campaign options and look at the various skill XP costs settings

Attach your files

Skills.png

Relevant log lines

MegaMek Suite Version

v0.51.01 (own build)

Operating System

Windows 11

Java Version

Eclipse Adoptium 21.0.10

Before you submit

• This report only contains one issue or request, and I haven't already reported it

• I am on the right repository - MegaMek for battles, MegaMekLab for unit design, MekHQ for campaigns, mm-data for unit and planet data

• I have asked about this on the MegaMek Discord (optional)

[AlexOldenburger]

This looks to be baked into the various campaign preset .xml files, where there is a difference between the way skills are set up.

    <skillType>
        <name>Gunnery/Mek</name>
        <target>7</target>
        <isCountUp>false</isCountUp>
        <subType>COMBAT_GUNNERY</subType>
        <firstAttribute>REFLEXES</firstAttribute>
        <secondAttribute>DEXTERITY</secondAttribute>
        <greenLvl>2</greenLvl>
        <regLvl>3</regLvl>
        <vetLvl>4</vetLvl>
        <eliteLvl>5</eliteLvl>
        <heroicLvl>6</heroicLvl>
        <legendaryLvl>7</legendaryLvl>
        <costs>16,8,8,8,8,8,8,8,-1,-1,-1</costs>
    </skillType>

    <skillType>
        <name>Perception</name>
        <target>7</target>
        <isCountUp>false</isCountUp>
        <subType>UTILITY</subType>
        <firstAttribute>INTELLIGENCE</firstAttribute>
        <secondAttribute>NO_ATTRIBUTE</secondAttribute>
        <greenLvl>1</greenLvl>
        <regLvl>3</regLvl>
        <vetLvl>4</vetLvl>
        <eliteLvl>5</eliteLvl>
        <heroicLvl>6</heroicLvl>
        <legendaryLvl>7</legendaryLvl>
        <costs>20,10,20,30,40,50,60,70,80,90,100</costs>
    </skillType>

The methods to initiate a SkillType also have this difference.

public static SkillType createGunneryMek() {
    return new SkillType(S_GUN_MEK,
          7,
          false,
          COMBAT_GUNNERY,
          REFLEXES,
          DEXTERITY,
          2,
          null,
          null,
          null,
          null,
          null,
          new Integer[] { 16, 8, 8, 8, 8, 8, 8, 8, DISABLED_SKILL_LEVEL, DISABLED_SKILL_LEVEL,
                          DISABLED_SKILL_LEVEL }
    );
}

public static SkillType createPerception() {
    return new SkillType(S_PERCEPTION,
          7,
          false,
          UTILITY,
          INTELLIGENCE,
          NO_ATTRIBUTE,
          null,
          null,
          null,
          null,
          null,
          null,
          new Integer[] { 20, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100 }
    );
}

But I may be missing something here?

[IllianiBird]

Fixed in the currently nightly. Closing :)