fix problem with incorrect error message on many of 200-th webrequest errorcodes#5922
Open
gorbovskoy-evg wants to merge 1 commit intomasterfrom
Conversation
Grantim
approved these changes
Apr 16, 2026
…brequest errorcodes add comment revert wrong commit add comment and correct order ob checks Revert "add comment" This reverts commit a6f3a36.
gorbovskoy-evg
force-pushed
the
fix_problem_with_incorrect_error_message_on_many_of_200-th_webrequest_errorcodes
branch
from
e99b136 to
2c1a989
Compare
Fedr
reviewed
Apr 17, 2026
| if ( code == 0 ) | ||
| return MR::unexpected( "Bad internet connection." ); | ||
|
|
||
| if ( response["code"].asInt() == 403 ) |
Contributor
There was a problem hiding this comment.
Do you reach this line after above additions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.