-
Notifications
You must be signed in to change notification settings - Fork 26
Hygroscopicity MS11 ratio option #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
daf5462
335fb3e
37d746f
f1e20da
3a351f6
3af1d9f
2fdb5c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -156,7 +156,7 @@ SUBROUTINE ukca_volume_mode( glomap_variables_local, nbox, nd, md, mdt, & | |
| USE ukca_config_constants_mod, ONLY: rho_water, avogadro, rho_so4 | ||
|
|
||
| USE ukca_mode_setup, ONLY: nmodes, nanion, ncation, & | ||
| cp_su, cp_oc, cp_cl, & | ||
| cp_su, cp_oc, cp_cl, cp_bc, & | ||
| cp_so, cp_nh4, cp_no3, cp_nn | ||
|
|
||
| USE yomhook, ONLY: lhook, dr_hook | ||
|
|
@@ -240,6 +240,7 @@ SUBROUTINE ukca_volume_mode( glomap_variables_local, nbox, nd, md, mdt, & | |
| REAL :: mmwrhow | ||
| REAL :: f_ao | ||
| REAL :: cl(nbox,-nanion:ncation) !ION CONCS (MOL/CC OF AIR) | ||
| REAL :: mdcopy(nbox,nmodes,glomap_variables_local%ncp) !Redistributes ions for solinsol | ||
|
|
||
| REAL :: tmp1(nbox,nmodes) | ||
| ! | ||
|
|
@@ -297,6 +298,7 @@ SUBROUTINE ukca_volume_mode( glomap_variables_local, nbox, nd, md, mdt, & | |
|
|
||
| denom(:)=0.0 ! define on all points to avoid error | ||
| denom2(:)=0.0 | ||
| mdcopy(:,:,:) = md(:,:,:) ! assigning md input values to mdcopy | ||
|
|
||
| ! Correct relative humidities to lie within the range of 10-90% | ||
| corrh(:)=rh(:) | ||
|
|
@@ -348,8 +350,20 @@ SUBROUTINE ukca_volume_mode( glomap_variables_local, nbox, nd, md, mdt, & | |
| cl(:,i)=0.0 ! set all concentrations to zero initially | ||
| END DO | ||
|
|
||
| ! If SOLINSOL then redistribute sulphate md into other species | ||
| IF (glomap_config%i_mode_setup == 11) THEN | ||
| mdcopy(:,imode,cp_su) = glomap_config%solinsol_hygro_ratio(1)* & | ||
| (mdcopy(:,imode,cp_su)) | ||
| mdcopy(:,imode,cp_cl) = glomap_config%solinsol_hygro_ratio(2)* & | ||
| (mdcopy(:,imode,cp_su)) | ||
| mdcopy(:,imode,cp_bc) = glomap_config%solinsol_hygro_ratio(3)* & | ||
| (mdcopy(:,imode,cp_su)) | ||
| mdcopy(:,imode,cp_oc) = glomap_config%solinsol_hygro_ratio(4)* & | ||
| (mdcopy(:,imode,cp_su)) | ||
| END IF | ||
|
|
||
| IF (component(imode,cp_su)) THEN ! assume all H2SO4 --> SO4 | ||
| cl(:,-2)=md(:,imode,cp_su)/avogadro ! [SO4] in moles/cc (air) | ||
| cl(:,-2)=mdcopy(:,imode,cp_su)/avogadro ! [SO4] in moles/cc (air) | ||
| END IF | ||
|
|
||
| IF (component(imode,cp_so)) THEN | ||
|
|
@@ -362,7 +376,7 @@ SUBROUTINE ukca_volume_mode( glomap_variables_local, nbox, nd, md, mdt, & | |
| END IF | ||
|
|
||
| IF (component(imode,cp_oc)) THEN | ||
| cl(:,-2)=cl(:,-2)+(fhyg_aom/avogadro)*(md(:,imode,cp_oc)/f_ao) | ||
| cl(:,-2)=cl(:,-2)+(fhyg_aom/avogadro)*(mdcopy(:,imode,cp_oc)/f_ao) | ||
| ! .. Increment concentration of SO4 ions to represent the | ||
| ! .. presence of hygroscopic aged organic aerosol mass in CP_OC. | ||
| ! .. Assume it has uptake behaviour at fraction FHYG_AOM of SO4. | ||
|
|
@@ -377,8 +391,8 @@ SUBROUTINE ukca_volume_mode( glomap_variables_local, nbox, nd, md, mdt, & | |
| END IF | ||
|
|
||
| IF (component(imode,cp_cl)) THEN ! assume complete dissociation | ||
| cl(:,3)=md(:,imode,cp_cl)/avogadro ! [Na] in moles per cc (air) | ||
| cl(:,-4)=md(:,imode,cp_cl)/avogadro ! [Cl] in moles per cc (air) | ||
| cl(:,3)=mdcopy(:,imode,cp_cl)/avogadro ! [Na] in moles per cc (air) | ||
| cl(:,-4)=mdcopy(:,imode,cp_cl)/avogadro ! [Cl] in moles per cc (air) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like there is no equivalent to this for cp_bc? If not, then there doesn't seem much point in adding in cp_bc since it is never used? Also, why do you only use the new md values for the concentration (cl) calculations and not in the rest of the routine that also uses md?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are correct that cp_bc is never used. I think its important to have an input for black carbon so that we are taking percentages across the 4 species (sulphate, sea salt, organic carbon and black carbon) however there is no need to actually include it in this script. My logic was to keep everything in, even if it isn't used to show consistency but I will remove the bc stuff as you are correct it doesn't need to actually be in this script. |
||
| END IF | ||
|
|
||
| ! Nitrate scheme | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? Since mdcopy(:,imode,cp_su) will have been changed by the line above? Shouldn't you use the original md(:,imode,cp_su) arrays to calculate mdcopy, instead of using mdcopy itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is a very good point. You are correct that by using mdcopy throughout we are making everything much smaller as we are compounding the changes. I am addressing this in the next commit and will rerun tests after I have addressed all your comments