This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Update keyrings and switch to using getAppKey#45
Closed
Gudahtt wants to merge 1 commit into
Closed
Conversation
Both `eth-simple-keyring` and `eth-hd-keyring` have been updated to `v4.0.0`. This version replaces the `withAppKeyOrigin` option with the `getAppKey` method, which returns the private app key. Various options have also been removed, if they were used solely to pass along the removed `withAppKeyorigin` option.
Member
Author
|
This depends upon both MetaMask/eth-simple-keyring#35 and MetaMask/eth-hd-keyring#19 , and v4.0.0 of both packages being published. I can bump the version of this package as well, once those two are published. |
Contributor
|
I'll close this for now while we await MetaMask/eth-simple-keyring#35 and MetaMask/eth-hd-keyring#19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
eth-simple-keyringandeth-hd-keyringhave been updated tov4.0.0. This version replaces thewithAppKeyOriginoption with thegetAppKeymethod, which returns the private app key.Various options have also been removed, if they were used solely to pass along the removed
withAppKeyoriginoption.