Conversation
| - Corresponding action types are available as well. | ||
| - Refactor pending withdraw/deposit tracking to FIFO queue design ([#8333](https://github.com/MetaMask/core/pull/8333)) | ||
| - Add `completeWithdrawalFromHistory` method for FIFO-based withdrawal completion matching ([#8333](https://github.com/MetaMask/core/pull/8333)) | ||
| - Add `lastCompletedWithdrawalTimestamp` and `lastCompletedWithdrawalTxHashes` state fields ([#8333](https://github.com/MetaMask/core/pull/8333)) |
There was a problem hiding this comment.
Will this require a migration on the client side? If so it should be marked as a breaking change and the package should be bumped by a major.
There was a problem hiding this comment.
This is adding state right? Shouldn't require a migration?
There was a problem hiding this comment.
I see that you have defaults defined for these properties, so no, no migration should be needed on the client side.
However, sometimes adding state properties causes type errors in the clients, particularly as it relates to the :stateChange event and the messenger type. We may have more guidance on this in future but I would be a bit cautious about this and double-check that this won't cause any type errors when you upgrade to this version on the client side. If you think this is okay then you are free to merge.
There was a problem hiding this comment.
Oh, I see there were other breaking changes in this release anyway. I must have missed those. If this ends up being breaking then it is already partially covered by the major bump anyway, so not as big of a deal anymore.
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 50d9a27. Configure here.
| ### Changed | ||
|
|
||
| - Refactor pending withdraw/deposit tracking to FIFO queue design ([#8333](https://github.com/MetaMask/core/pull/8333)) | ||
|
|
There was a problem hiding this comment.
Stray blank line breaks Changed section list continuity
Low Severity
Moving the "Refactor pending withdraw/deposit tracking to FIFO queue design" entry from the Added section to the Changed section introduced a stray blank line (line 72) between that entry and the next one. This splits the ### Changed markdown list into two separate lists, which is inconsistent with every other section in the changelog (e.g., ### Added, ### Fixed, ### Removed all have contiguous list items). This may also cause @metamask/auto-changelog validation to fail.
Reviewed by Cursor Bugbot for commit 50d9a27. Configure here.
There was a problem hiding this comment.
It would be ideal to remove the blank line from a formatting perspective, but shouldn't break auto-changelog.
|
|
||
| - **BREAKING:** Remove `adaptMarketFromMYX`, `adaptPriceFromMYX`, `adaptMarketDataFromMYX`, `filterMYXExclusiveMarkets`, `isOverlappingMarket`, `buildPoolSymbolMap`, `buildSymbolPoolsMap`, and `extractSymbolFromPoolId` from the public package exports to prevent `@myx-trade/sdk` from being included in the static webpack bundle ([#8398](https://github.com/MetaMask/core/pull/8398)) | ||
| - These functions are still used internally by `MYXProvider`, which is loaded via dynamic import | ||
| - Consumers that imported these utilities directly should instead import from `@metamask/perps-controller/src/utils/myxAdapter` or duplicate the logic locally |
There was a problem hiding this comment.
Heads up that this probably won't work. Arbitrary subpath exports aren't supported in core packages. You would need to add explicit exports to package.json. Is this going to be a problem? Just want to double-check.
There was a problem hiding this comment.
MYX is temporal for now, so no issues here. But good to know it wont work
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
One more comment but this looks good to go otherwise.
2 participants
Explanation
Release 906.0.0 bumps
@metamask/perps-controllerfrom2.0.0to2.1.0.Changes included
@metamask/perps-controllerv2.1.0generate-action-typesCLI into@metamask/messenger-cli(#8378)generate-action-typesCLI tool as subpath export to messenger (#8264)References
Checklist
Note
Medium Risk
Primarily version/changelog bookkeeping, but it publishes
@metamask/perps-controlleras a new major (2.0.0->3.0.0), which can introduce breaking changes for consumers depending on updated exports/APIs.Overview
Bumps the monorepo release version to
906.0.0and publishes@metamask/perps-controller3.0.0(from2.0.0).Updates the perps-controller changelog to add the
3.0.0release section and adjust compare links accordingly.Reviewed by Cursor Bugbot for commit 50d9a27. Bugbot is set up for automated code reviews on this repo. Configure here.