Skip to content

drop support for Node.js versions 16, 21#109

Merged
legobeat merged 2 commits into
MetaMask:mainfrom
legobeat:node-18
Oct 14, 2024
Merged

drop support for Node.js versions 16, 21#109
legobeat merged 2 commits into
MetaMask:mainfrom
legobeat:node-18

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Oct 3, 2024

  • Drop support for Node.js versions 16, 21
  • Add Node.js v22 to CI matrix
  • ci: yarn --ignore-engines to work around out of date eslint-plugin-jsdoc

Related

Blocking

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Oct 3, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/generator@7.23.0 None 0 487 kB nicolo-ribaudo
npm/@babel/parser@7.23.0 None 0 1.89 MB nicolo-ribaudo
npm/@types/node@18.19.54 None 0 2.02 MB types
npm/undici-types@5.26.5 None 0 73.1 kB ethan_arrowood

🚮 Removed packages: npm/@babel/generator@7.22.15, npm/@babel/parser@7.22.16, npm/@types/node@16.18.46

View full report↗︎

Resolves:

 error eslint-plugin-jsdoc@43.0.7: The engine "node" is incompatible with this module. Expected version "^14 || ^16 || ^17 || ^18 || ^19 || ^20". Got "22.9.0"

ignore-engines is default behavior in newer yarn versions.
@legobeat legobeat merged commit 08c725b into MetaMask:main Oct 14, 2024
@legobeat legobeat deleted the node-18 branch October 14, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants