Conversation
📖 Storybook Preview |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b824c63. Configure here.
| ); | ||
|
|
||
| return ( | ||
| <Box twClassName={twClassName} {...props}> |
There was a problem hiding this comment.
Root container missing base gap-1 vertical spacing
Medium Severity
The root Box in TitleSubpage only passes the user-supplied twClassName with no base styles. This means there's no vertical gap between the identity row, amount row, and bottom rows. The test expects gap-1 on the container, but the component never applies it — neither via a gap={1} prop nor a base twClassName string. The README also states classes will be "merged with the component's default classes," implying base styles were intended but omitted.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b824c63. Configure here.


Description
Adds
TitleSubpageto@metamask/design-system-react-native: a layout for subpage headers with a required identity row (leadingtitleAvatarin a 40×40 centered slot + title stack), optional subtitle, amount (display typography when a string), optional bottom label or bottom accessory, and end accessories on title, subtitle, amount, and bottom label rows.Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-583
Manual testing steps
yarn storybook:iosoryarn storybook:android).Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
Before
N/A — new component (or attach Storybook before/after if replacing something in-app).
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2026-04-08.at.21.41.11.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: this is a new React Native UI component plus Storybook/docs/tests and export wiring, with no changes to existing business logic beyond adding new type exports.
Overview
Adds
TitleSubpageto@metamask/design-system-react-native, providing a standardized subpage header layout with a requiredtitleAvataridentity row and optionalsubtitle,amount, end-accessories, and a mutually-exclusive bottom label vs custom bottom accessory.Wires the component into public exports (
components/index.ts), adds shared prop types in@metamask/design-system-shared, and includes Storybook stories, comprehensive RN tests, and a README; Storybook’s auto-generatedstorybook.requires.jsis updated to include the new stories.Reviewed by Cursor Bugbot for commit b824c63. Bugbot is set up for automated code reviews on this repo. Configure here.