Skip to content

Allow Ganache RPC methods in e2e test #18149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gudahtt wants to merge 1 commit into from
Closed

Allow Ganache RPC methods in e2e test #18149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions app/scripts/controllers/permissions/specifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,29 @@ function validateCaveatAccounts(accounts, getIdentities) {
});
}

// Environment variable injection does not work with destructuring
// eslint-disable-next-line prefer-destructuring
const IN_TEST = process.env.IN_TEST;

/**
* These are methods supported by Ganache, for use in e2e tests.
*
* @see {@link https://ganache.dev/}
*/
const ganacheMethods = [
'evm_addAccount',
'evm_increaseTime',
'evm_mine',
'evm_removeAccount',
'evm_revert',
'evm_setAccountBalance',
'evm_setAccountCode',
'evm_setAccountNonce',
'evm_setAccountStorageAt',
'evm_setTime',
'evm_snapshot',
];

/**
* All unrestricted methods recognized by the PermissionController.
* Unrestricted methods are ignored by the permission system, but every
Expand Down Expand Up @@ -276,4 +299,5 @@ export const unrestrictedMethods = Object.freeze([
'wallet_watchAsset',
'web3_clientVersion',
'web3_sha3',
...(IN_TEST ? ganacheMethods : []),
]);