fix: cancel resolved timer timeouts - #2470
Open
DePasqualeOrg wants to merge 1 commit into
Open
Conversation
|
|
@DePasqualeOrg is attempting to deploy a commit to the Milkdown Team on Vercel. A member of the Team first needs to authorize it. |
DePasqualeOrg
marked this pull request as ready for review
September 6, 2026 17:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was developed with Codex using GPT-6 Astra and went through several rounds of automated review. It resolves a real issue that I encountered while using this library.
Summary
Resolved context timers leave timeout callbacks queued until their deadlines. This PR cancels those callbacks during listener cleanup, releasing resources and preventing callbacks from running after teardown.
How did you test this change?
pnpm test:unit --maxWorkers=2passes all 471 tests.pnpm build:tscandpnpm test:lint --threads 2pass. The new fake-timer regression fails without the fix.