Skip to content

fix: cancel resolved timer timeouts - #2470

Open
DePasqualeOrg wants to merge 1 commit into
Milkdown:mainfrom
DePasqualeOrg:codex/cancel-resolved-timer-timeouts
Open

fix: cancel resolved timer timeouts#2470
DePasqualeOrg wants to merge 1 commit into
Milkdown:mainfrom
DePasqualeOrg:codex/cancel-resolved-timer-timeouts

Conversation

@DePasqualeOrg

@DePasqualeOrg DePasqualeOrg commented Sep 6, 2026

Copy link
Copy Markdown

This PR was developed with Codex using GPT-6 Astra and went through several rounds of automated review. It resolves a real issue that I encountered while using this library.

  • I read the contributing guide.
  • I agree to follow the code of conduct.

Summary

Resolved context timers leave timeout callbacks queued until their deadlines. This PR cancels those callbacks during listener cleanup, releasing resources and preventing callbacks from running after teardown.

How did you test this change?

pnpm test:unit --maxWorkers=2 passes all 471 tests. pnpm build:tsc and pnpm test:lint --threads 2 pass. The new fake-timer regression fails without the fix.

@changeset-bot

changeset-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

鈿狅笍 No Changeset found

Latest commit: 513fee3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

@DePasqualeOrg is attempting to deploy a commit to the Milkdown Team on Vercel.

A member of the Team first needs to authorize it.

@DePasqualeOrg
DePasqualeOrg marked this pull request as ready for review September 6, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant