Skip to content

fix(components): preserve pointer events on non-task list markers - #2471

Open
DePasqualeOrg wants to merge 1 commit into
Milkdown:mainfrom
DePasqualeOrg:codex/list-marker-pointer-events
Open

fix(components): preserve pointer events on non-task list markers#2471
DePasqualeOrg wants to merge 1 commit into
Milkdown:mainfrom
DePasqualeOrg:codex/list-marker-pointer-events

Conversation

@DePasqualeOrg

@DePasqualeOrg DePasqualeOrg commented Sep 6, 2026

Copy link
Copy Markdown

This PR was developed with Codex using GPT-6 Astra and went through several rounds of automated review. It resolves a real issue that I encountered while using this library.

  • I read the contributing guide.
  • I agree to follow the code of conduct.

Summary

Bullet and ordered-list markers cancel pointer events despite having no checkbox to toggle. This PR leaves those events available for selection handling while preserving task-checkbox toggling.

How did you test this change?

pnpm test:unit --maxWorkers=2 passes all 474 tests. pnpm build:tsc and pnpm test:lint --threads 2 pass. The new component tests cover propagation, cancellation and both checkbox states; the two non-task cases fail without the fix.

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

@DePasqualeOrg is attempting to deploy a commit to the Milkdown Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3fb3226

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DePasqualeOrg
DePasqualeOrg marked this pull request as ready for review September 6, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant