Skip to content

fix: Fixing debugger crash with breakpoints #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexDenfordSkyboxLabs merged 2 commits into from
Jul 29, 2026
Merged

fix: Fixing debugger crash with breakpoints #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57fd004
fix
AlexDenfordSkyboxLabs Jul 29, 2026
e848131
Update session.ts
AlexDenfordSkyboxLabs Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/protocol-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,16 +179,9 @@ export interface ResumeMessage {
type: OutgoingEventType.Resume;
}

export interface RequestLegacyMessage {
type: OutgoingEventType.Request;
request: { request_seq: number; command: string; args: unknown };
}

export interface RequestMessage {
type: OutgoingEventType.Request;
request_seq: number;
command: string;
args: unknown;
request: { request_seq: number; command: string; args: unknown };
}

export interface BreakpointsLegacyMessage {
Expand Down Expand Up @@ -228,7 +221,6 @@ export type OutgoingDebuggeeMessage =
| StopProfilerMessage
| StopOnExceptionMessage
| ResumeMessage
| RequestLegacyMessage
| RequestMessage
| BreakpointsLegacyMessage
| BreakpointsMessage
Expand Down
26 changes: 7 additions & 19 deletions src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ import {
StoppedEventMessage,
ThreadEventMessage,
DebuggeeResponseEnvelope,
RequestLegacyMessage,
DiagnosticsDescriptorMessage,
} from './protocol-events';
import { SourceMaps } from './source-maps';
Expand Down Expand Up @@ -921,27 +920,16 @@ export class Session extends DebugSession implements IDebuggeeMessageSender {
this.sendDebuggeeMessage(this.makeRequestPayload(requestSeq, response.command, args));
}

private makeRequestPayload(requestSeq: number, responseCommand: string, args: unknown): RequestMessage | RequestLegacyMessage {
if (this._clientProtocolVersion >= ProtocolVersion.SupportCerealSerialization) {
const envelope: RequestMessage = {
type: OutgoingEventType.Request,
private makeRequestPayload(requestSeq: number, responseCommand: string, args: unknown): RequestMessage {
const envelope: RequestMessage = {
type: OutgoingEventType.Request,
request: {
request_seq: requestSeq,
command: responseCommand,
args,
};
return envelope;
}
else {
const envelope: RequestLegacyMessage = {
type: OutgoingEventType.Request,
request: {
request_seq: requestSeq,
command: responseCommand,
args,
},
};
return envelope;
}
},
};
return envelope;
}

public sendDebuggeeMessage(envelope: OutgoingDebuggeeMessage): void {
Expand Down
Loading