feat: Implemented tech for enabling and disabling live diagnostics by tab - #402
Open
AlexDenfordSkyboxLabs wants to merge 1 commit into
Open
feat: Implemented tech for enabling and disabling live diagnostics by tab#402AlexDenfordSkyboxLabs wants to merge 1 commit into
AlexDenfordSkyboxLabs wants to merge 1 commit into
Conversation
frgarc
approved these changes
Aug 5, 2026
| <title>Minecraft Diagnostics</title> | ||
| <script nonce="${nonce}"> | ||
| window.initialParams = { showReplayControls: ${showReplayControls} }; | ||
| window.initialParams = ${JSON.stringify({ showReplayControls, diagnosticsTabStates })}; |
Contributor
There was a problem hiding this comment.
Why is this not receiving the object instead of the string?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All live diagnostics are now disabled by default
Added a new button next to each tab for toggling the enable/disable
When diagnostics are disabled, the UI won't display and the extension tells Minecraft to not send the diagnostics data through to the extension.
We save the state of enabled/disabled of each each, to local disk so that it persists your settings/choices.