Fix OOB write in fillExtraMM nonce handling#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fillExtraMMcode trusted theTX_EXTRA_NONCEdeclared length byte and copied a 35-byte merged-mining tag without verifying the actual payload was present, leading to an out-of-bounds write and possible native heap corruption.Description
extra_nonce_startandextra_nonce_start + extra_nonce_sizeare withinminer_tx.extrabefore modifying the vector.extra_nonce_sizeis at leastMM_NONCE_SIZEand computenew_extra_nonce_sizeas an unsignedsize_t.static_cast<uint8_t>and copy the merged-mining tag to a destination offset derived from the validatedextra_nonce_startandnew_extra_nonce_size, preserving original behavior for valid inputs.Testing
nl -ba src/main.cc | sed -n '96,135p'to verify the new logic in context.Codex Task