Merged
Conversation
ffarall
approved these changes
Oct 3, 2024
Comment on lines
7
to
8
| use sp_trie::Trie; | ||
| use sp_trie::{TrieDBBuilder, TrieLayout}; |
Collaborator
There was a problem hiding this comment.
Suggested change
| use sp_trie::Trie; | |
| use sp_trie::{TrieDBBuilder, TrieLayout}; | |
| use sp_trie::{TrieDBBuilder, TrieLayout, Trie}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades dependencies to polkadot-sdk v1.10.0. Notable changes:
get_claim_foranditer_claims_at_depthmethods, useful for checking which parachains had claims over which cores at a certain depth (blocks in the future, depth 0 = very next block)StorageItem::<T, I>::get()is used insteadteleport_assetsandreserve_transfer_assets. NOTE: No change needed since we use the generictransfer_assetsexecuteandsendforexecute_blobandsend_blob. NOTE: Updated xcm-simulator tests to change deprecated functions in this PR.on_idle. NOTE: Implemented in this PR, but IdleMaxServiceWeight (the maximum weight to be used from remaining weight for processing enqueued messages on idle) is set to a placeholder, we should update it after benchmarking.schedule_code_upgradeto not wait for the parachain to progress (useful to know, it's now easier to unbrick a parachain)execute_blobandsend_blob(which require as input the encoded XCM)Critical warning: since storage from
cumulus-pallet-parachain-systemis made public in polkadot-sdk v1.13.0 and itspallet::getters have been removed, we have to mock getting from its storage. This HAS to be removed when upgrading to v1.13.0.