feat: ⏫ upgrade to Polkadot SDK v1.11.0 - #212
Merged
Merged
Conversation
snowmead
approved these changes
Oct 1, 2024
snowmead
left a comment
Contributor
There was a problem hiding this comment.
All looks good, just wanted to clarify the use of having both rust-libp2p and litep2p network backends.
ffarall
approved these changes
Oct 3, 2024
ffarall
left a comment
Collaborator
There was a problem hiding this comment.
Again, outstanding PR docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update from Polkadot SDK 1.10.0 to 1.11.0
Changelog for
Node Dev:candidates_pending_availabilityruntime API, which returns all the candidates for a parachain at a given relay block number (useful for elastic scaling)para_id()from CoreState in polkadot primitives in favor of direct usage of ClaimQueue (which provides a better view of what’s scheduled on each core). Again, useful to know for elastic scalingTransactionEventsframe-omni-bencherthat allows to directly benchmark a WASM blob without needing a node or chain spec, making it easier to generate pallet weights. It works for all FRAME runtimes that don’t have 3rd party host calls (we don’t) or nonBlakeTwo256block hashing (we do) so it should work for us. It is backwards compatible with the old CLI args too.—runtimeand—genesis-builder=none|runtime|specarguments to thebenchmark palletcommandPalletCmd::run:run()is deprecated, we either remove all benchmark code from the Node and use the new omni-bencher or change it forrun_with_spec().run_with_spectemporarily, although when we start benchmarking we should remove all benchmarking code from the node and use theomni-bencheras recommended.local,staging, etc). To use them, the ChainSpecBuilder is extended with thewith_genesis_config_preset_namemethod.GenesisBuilderAPI changed to make use of these presets, I already updated it on our runtime but we don’t have any presets yet, it’s worth exploring if we could make good use of them. Usage example for Rococo herelitep2pintegrated into Polkadot SDK improving performance but not fully replacingrust-libp2pyet.NetworkBackendtype, which can be good old libp2p or new flashy litep2p. Took a while 😮💨slot_durationfromaura::collators::basic::Params, it now has to be fetched using Aura’s runtime APInode/src/service.rs+ removed unneeded code fromnode/src/command.rs(logging parachain account)Changelog for
Runtime Dev:pallet-brokerto get the current price of a core in the ongoing saleframe/examplesandMigrationIdto frame-supportCurrencytoFungibleFungibleAdapterandfile-systempallet since it was using the to-be-deprecated Currency traitdynamic_paramsname expand onpallet-parametersvalidate_unsignedhook forframe-systemallows valid tasks to be submitted as unsigned transactionsis_validcall on a task is the one that validates if the task is valid to be submitted as an unsigned transaction. As such, to prevent DoS attacks, it has to be cheap with minimal to no storage reads.substrate/frame/examples/tasks/AllowHrmpNotificationsFromRelayChainbarrier for safety (to ensure HRMP notifications originate solely from the Relay Chain)xcm-simulatorand the actual runtime.hrmp.establish_channel_with_systemcall to allow parachains to establish a channel with a system parachainTryRuntimesubcommand from node (we should use the standalone CLI https://github.com/paritytech/try-runtime-cli)execute_blobandsend_bloband restoringexecuteandsendExtra changes:
CheckMetadataHashextension according to RFC 0078 (also check #4274)