Don't force int16 conversion in nonrigid.transform_data#1230
Open
ethanbb wants to merge 1 commit intoMouseLand:mainfrom
Open
Don't force int16 conversion in nonrigid.transform_data#1230ethanbb wants to merge 1 commit intoMouseLand:mainfrom
ethanbb wants to merge 1 commit intoMouseLand:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an integer overflow that I encountered when using
registration_wrapperon arrays that were not int16 type. Specifically, the values in my data were in the range of uint16, and the cast to int16 (short) type at the end oftransform_datacaused some values to wrap around to very negative int16 values. With this change, the output ofregistration_wrapperwill be the same type as the input.I realize that in other parts of the software, data arrays are expected to be in int16 format, and other features might not be expected to work correctly if this is violated. However, empirically, at least
registration_wrapperwith an input and output memmapped array of another dtype worked fine with this change.