feat(shop): add loading skeleton and empty state to products grid (closes #105) - #299
Open
Ranjeet2063 wants to merge 1 commit into
Open
Ranjeet2063 wants to merge 1 commit into
Ranjeet2063 wants to merge 1 commit into
Conversation
|
@Ranjeet2063 is attempting to deploy a commit to the Oluremi's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Resolves issue #105 by adding loading and empty states to the shop products grid in
app/shop/page.jsx.Key Changes
loadingstate (defaults totrue) during initiallistProductsfetch.ProductGridSkeletonfromcomponents/Skeleton.tsxwhileloadingis true.loadingresolves andproducts.length === 0without error, displays an explicit "No products yet" empty message.listProductsrejects.tests/app/shop/page.test.tsxtesting:ProductGridSkeletonis rendered while pending.Verification (2x Verified)
npx vitest run tests/app/shop/page.test.tsx(4/4 tests pass)npm run type-check(0 errors)npm run lint(0 errors)npx prettier --check(100% formatted)Closes #105