chore(components): remove six never-imported UI components (closes #30) - #339
Open
Ranjeet2063 wants to merge 1 commit into
Open
Ranjeet2063 wants to merge 1 commit into
Ranjeet2063 wants to merge 1 commit into
Conversation
…valabs-crew#30) - Remove dead/never-imported UI components under components/: - components/ErrorBoundary.tsx - components/Notification.tsx - components/Skeleton.tsx - components/OptimizedImage.tsx - components/SkipLink.tsx - components/ProtectedLink.jsx - Verified 0 remaining imports or symbol usages repository-wide - Verified npm run lint, npm run type-check, and npm run build pass cleanly
|
@Ranjeet2063 is attempting to deploy a commit to the Oluremi's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes (Closes #30)
This PR resolves Issue #30 by removing six dead, never-imported UI components under
components/:components/ErrorBoundary.tsxcomponents/Notification.tsxcomponents/Skeleton.tsxcomponents/OptimizedImage.tsxcomponents/SkipLink.tsxcomponents/ProtectedLink.jsxDeletion Rationale & Verification
git grepconfirmed that none of these components were imported anywhere acrossapp/,components/,lib/,context/, ortests/.ProtectedLink.jsxhad broken imports using Next.js Pages router (next/router) and routes to non-existent/login.SkipLink.tsxexpected an element withid="main-content"which was not implemented inlayout.jsx.Acceptance Criteria Passed
rgfor each component symbol returns no references outside the deleted filesnpm run lint(next lint) passes with 0 errorsnpm run type-check(tsc --noEmit --skipLibCheck) passes cleanlynpm run build(next build) produces optimized production build without errors