Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Fixes radio button hover state#1339

Merged
bluemarvin merged 2 commits into
masterfrom
radio_button_hover_state
Jun 28, 2019
Merged

Fixes radio button hover state#1339
bluemarvin merged 2 commits into
masterfrom
radio_button_hover_state

Conversation

@keianhzo

Copy link
Copy Markdown
Contributor

Fixes #1196 Fixes radio button hover state styles

@keianhzo

keianhzo commented Jun 19, 2019

Copy link
Copy Markdown
Contributor Author

I find the new spec a bit confusing though, when you check an option, as the pointer is on top of the radio button, it shows the grey hovered state instead of the checked state which might confuse the user.

@jvonitter

Copy link
Copy Markdown
Contributor

Thanks Manuel! Can we pass an apk to Nadja and team for them to see what you mean about the button state?

@keianhzo

Copy link
Copy Markdown
Contributor Author

@thenadj You can test the spec implementation in this APK: https://send.firefox.com/download/2f0aedb434403033/#G-whCzmp4Yt7h14j6tWvZg

Please see my comments above. Thanks!

@thenadj

thenadj commented Jun 20, 2019

Copy link
Copy Markdown

@keianhzo I agree, the states were not specd correctly. Attached is the updated version. I'll also add it to GH-1196

UIS-66 Toggle and Radio Button States_003.pdf

@keianhzo keianhzo force-pushed the radio_button_hover_state branch from 1634853 to b3804e4 Compare June 24, 2019 09:47
@keianhzo

Copy link
Copy Markdown
Contributor Author

@thenadj

thenadj commented Jun 24, 2019

Copy link
Copy Markdown

@keianhzo Thanks for updating the radio buttons. They look great now.

@keianhzo keianhzo requested a review from MortimerGoro June 25, 2019 08:32
@MortimerGoro

Copy link
Copy Markdown
Contributor

I find the hover color for checked radio button confusing. It feels like the button is not checked when hovered

@thenadj

thenadj commented Jun 25, 2019

Copy link
Copy Markdown

Ok, let's add 'hover-select' state. See updates in attached UIS-66.
UIS-66 Toggle and Radio Button States_004.pdf

@jvonitter
UIS-66 also includes hover for the toggle controls. Is this work tracked somewhere?

@keianhzo

Copy link
Copy Markdown
Contributor Author

@thenadj @MortimerGoro Updated according to the latest spec, also added the Switch spec as I couldn't find any open issue for that.

https://send.firefox.com/download/ae9485dfaf47b9b2/#C7W1IKwQQ2wlNPAw3u3OUw

@bluemarvin

Copy link
Copy Markdown
Contributor

I don't see the color change on hover for off state of the switch.

@keianhzo

Copy link
Copy Markdown
Contributor Author

@bluemarvin I think the hover color difference between checked-hover and unchecked-hover is too subtle, do you mean that or you just don't see any change when you hover on an unchecked option and it just remains unchecked?

@bluemarvin

Copy link
Copy Markdown
Contributor

@bluemarvin I think the hover color difference between checked-hover and unchecked-hover is too subtle, do you mean that or you just don't see any change when you hover on an unchecked option and it just remains unchecked?

I just don't see a difference between the off hover color red and the off selected state. They look exactly the same to me. So either it isn't working or they are too close to the same shade of red.

@bluemarvin

Copy link
Copy Markdown
Contributor

The off switch color should be done in follow up.

@bluemarvin bluemarvin merged commit 1e611da into master Jun 28, 2019
MortimerGoro pushed a commit that referenced this pull request Jul 1, 2019
* Fixes radio button hover state


wip

* Updated hover and switch specs
@philip-lamb philip-lamb deleted the radio_button_hover_state branch July 1, 2019 21:38
MortimerGoro pushed a commit that referenced this pull request Jul 2, 2019
* Fixes radio button hover state


wip

* Updated hover and switch specs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Radio button should hover state when raycast pointed on

5 participants