This repository was archived by the owner on Jul 22, 2024. It is now read-only.
WIP Megazord support#1418
Closed
grigoryk wants to merge 9 commits into
Closed
Conversation
added 7 commits
July 17, 2019 16:11
No functional changes, just a java->kotlin conversation with some manual tweaks.
…en at the top level
This PR integrates FxA account manager and adds just enough code to allow signing-in via settings, signing out, synchronizing bookmarks and receiving tabs sent from other Firefox devices. TODO: - bookmarks UI needs folder support - better account management UI, currently there are just sign-in/sign-out buttons - megazord configuration?
This makes sure we see synced bookmarks in the library right after signing-in.
Contributor
Author
|
Once mozilla-mobile/android-components#3806 lands (and by then #1417, hopefully), I'll push an updated version of this PR. |
grigoryk
force-pushed
the
megazord
branch
2 times, most recently
from
2d8ad71 to
0cea904
Compare
Contributor
Author
|
Hmm, that kotlin conversion may make it tricky to rebase We should consider just landing the megazord stuff on |
added 2 commits
July 18, 2019 14:54
(currently built against local versions of a-c, since upstream work is still inflight) This PR upgrades a-c to 5.0.0, which is now using 0.35.0 appservices release that introduces a "default megazord", which is what the consuming application now uses by default. See megazord docs: https://mozilla.github.io/application-services/docs/applications/consuming-megazord-libraries.html TODO - we want to use Gecko's network stack
Contributor
|
@grigoryk Does this need to be part of the FxA feature branch? |
bluemarvin
force-pushed
the
feature/fxa
branch
from
87816ad to
46e04d5
Compare
keianhzo
force-pushed
the
feature/fxa
branch
2 times, most recently
from
fad87ff to
f2cc211
Compare
keianhzo
force-pushed
the
feature/fxa
branch
3 times, most recently
from
a1fd175 to
37210d1
Compare
keianhzo
force-pushed
the
feature/fxa
branch
4 times, most recently
from
42ffe12 to
ef17358
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to land on top of #1417, so pertinent commits here are the last two. The rest are just #1417.
Currently merging this is blocked on mozilla-mobile/android-components#3806 landing.