Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Allow keyboard to be repositioned#1466

Merged
bluemarvin merged 5 commits into
masterfrom
experimental/keyboard_move
Jul 31, 2019
Merged

Allow keyboard to be repositioned#1466
bluemarvin merged 5 commits into
masterfrom
experimental/keyboard_move

Conversation

@MortimerGoro

Copy link
Copy Markdown
Contributor

Fixes #1146

@MortimerGoro MortimerGoro force-pushed the experimental/keyboard_move branch from 39274fb to b2e74bd Compare July 26, 2019 16:46

@bluemarvin bluemarvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the keyboard with curved windows feels off to me. Especially when moving to the extreme left as the keyboard starts to jitter.

Additionally, It doesn't seem there is a way to reset the keyboard to the default position?

Comment thread app/src/main/cpp/WidgetPlacement.h Outdated
Comment thread app/src/main/cpp/WidgetPlacement.h
Comment thread app/src/main/cpp/WidgetMover.cpp Outdated
Comment thread app/src/common/shared/org/mozilla/vrbrowser/browser/SettingsStore.java Outdated
@jvonitter

jvonitter commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

Additionally, It doesn't seem there is a way to reset the keyboard to the default position?

This is by design. Once users move it, they can move it wherever they want including the default position. It should reset once they leave the app.

@bluemarvin

Copy link
Copy Markdown
Contributor

Additionally, It doesn't seem there is a way to reset the keyboard to the default position?

This is by design. Once users move it, they can move it wherever they want including the default position. It should reset once they leave the app.

The keyboard position is saved between runs and there is no indication when the user has it back in the default position.

Additionally, I notice that you can move the keyboard farther to the right than to the left. This seems like an odd constraint.

@jvonitter

Copy link
Copy Markdown
Contributor

The keyboard position is saved between runs and there is no indication when the user has it back in the default position.

There's nothing really special about the specific default position. If a user wants it below the awesomebar, they can move it there. If they want it somewhere else, that's ok too. I think whether or not it should reset between runs is something we should consider after we use for a while. If it persists between sessions now, let's see how that feels and switch it if it's bad.

Additionally, I notice that you can move the keyboard farther to the right than to the left. This seems like an odd constraint.

That does seem weird and not intentional.

@MortimerGoro MortimerGoro force-pushed the experimental/keyboard_move branch from b2e74bd to 0f8fb84 Compare July 30, 2019 16:11
@MortimerGoro

MortimerGoro commented Jul 30, 2019

Copy link
Copy Markdown
Contributor Author

PR updated with:

  • Do not save keyboard movement after app is restarted
  • Fix clamping issues and use correct max values based on movement anchor point
  • Address review comments

@MortimerGoro

MortimerGoro commented Jul 30, 2019

Copy link
Copy Markdown
Contributor Author

I'll improve curved mode movement in a follow-up because I need the math improvements from the multiwindow branch which are not available yet in master.

Comment thread app/src/common/shared/org/mozilla/vrbrowser/browser/SettingsStore.java Outdated
@bluemarvin bluemarvin merged commit eb20078 into master Jul 31, 2019
@bluemarvin bluemarvin deleted the experimental/keyboard_move branch August 1, 2019 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow keyboard to be repositioned

3 participants