This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Dialog for requesting permission for storing voice samples#1507
Merged
Conversation
bluemarvin
suggested changes
Aug 5, 2019
bluemarvin
left a comment
bluemarvin
left a comment
Contributor
There was a problem hiding this comment.
The first time clicking on the voice search microphone shows the dialog to collect voice samples. If you decline, it doesn't continue on to do the voice search.
Contributor
Author
|
@bluemarvin Fixed |
bluemarvin
approved these changes
Aug 6, 2019
Contributor
|
I'm going to land this. If @MortimerGoro has any feedback it can be done in a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #641 A dialog has been added to ask the user for permission to store voice samples and transcriptions.