Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Update voice collection strings #1611

Merged
bluemarvin merged 1 commit into from
Aug 20, 2019
Merged

Update voice collection strings #1611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,11 +860,11 @@

<!-- This string is displayed in the title of the Voice Search samples collect dialog. That dialog is shown the first time
a user tries to use the voice search. -->
<string name="voice_samples_collect_dialog_title">Allow Firefox to Anonymously Collect Voice Samples?</string>
<string name="voice_samples_collect_dialog_title">Allow Firefox Reality to Collect Voice Samples for Research?</string>

@bluemarvin bluemarvin Aug 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized we shouldn't have Firefox or Firefox Reality in the strings file. See:

https://github.com/MozillaReality/FirefoxReality/blob/master/app/src/main/res/values/strings.xml#L243

I actually saw a few other places where the app name was hardcoded in the strings.xml file.


<!-- This string is displayed in the description of the Voice Search samples collect dialog. That dialog is shown the first time
a user tries to use the voice search. -->
<string name="voice_samples_collect_dialog_description">Your data is always anonymous and protected under our Personal Data Promise. We collect voice samples to improve the experience and performance of our products. You’ll always be able to use voice search, even if you don’t allow collection.&lt;a href="privacy">Learn More&lt;/a></string>
<string name="voice_samples_collect_dialog_description">Your data is always secure and never shared with third parties. We collect voice samples to improve the experience and performance of our products. You’ll always be able to use voice search, even if you don’t allow collection.&lt;a href="privacy">Learn More&lt;/a></string>

<!-- This string is displayed in the button of the Voice Search samples collect dialog.
When clicked the user opts out from the voice data collection. -->
Expand Down