This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Replace all the hardcoded Firefox strings#1612
Merged
Merged
Conversation
bluemarvin
suggested changes
Aug 21, 2019
bluemarvin
left a comment
bluemarvin
left a comment
Contributor
There was a problem hiding this comment.
I believe the string ID needs to be changed when it's contents change. Do I misunderstand how this is supposed to work?
Contributor
Author
|
@bluemarvin you are right, updated. |
bluemarvin
approved these changes
Aug 21, 2019
bluemarvin
left a comment
bluemarvin
left a comment
Contributor
There was a problem hiding this comment.
I wonder if we should just use numbers going forward? So:
security_options_crash_reports_send_data would become security_options_crash_reports_send_data2?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all the hardcoded Firefox strings