This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Title bar support#1613
Merged
Merged
Conversation
keianhzo
force-pushed
the
wip/title_bar
branch
3 times, most recently
from
e41ede4 to
7c03c7e
Compare
Contributor
Author
|
I have updated the title bar texts for home, private home and bookmarks. I've added a "Private Browsing" title when it the private browsing landing as it looked weird to be empty and hiding it doesn't feel consistent but let me know if that doesn't sound right and we can revert. |
keianhzo
force-pushed
the
wip/title_bar
branch
from
7c03c7e to
82b0860
Compare
bluemarvin
approved these changes
Aug 23, 2019
keianhzo
force-pushed
the
wip/title_bar
branch
from
82b0860 to
a65b551
Compare
MortimerGoro
approved these changes
Aug 23, 2019
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #519 Render the current document's
<title>in the browser UI/chrome