This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Fixes tooltips#1622
Merged
Merged
Conversation
bluemarvin
reviewed
Aug 21, 2019
bluemarvin
left a comment
bluemarvin
left a comment
Contributor
There was a problem hiding this comment.
What necessitated the switch to gecko.ThreadUtils? I ask because we are trying to remove all org.mozilla.gecko.* imports as that package is going to become private in GeckoView at some point.
Contributor
Author
|
Not too much, there are alternatives but we are already using it across the app. Maybe we can file a follow up to refactor and land this? |
Contributor
Okay, I was just curious what functionally the gecko.ThreadUtils added that the previous solution did not. |
bluemarvin
approved these changes
Aug 21, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tooltips not being displayed.