Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Correctly restore the bookmarks tray button state after showing a notification #1740

Merged
bluemarvin merged 1 commit into from
Sep 3, 2019
Merged

Correctly restore the bookmarks tray button state after showing a notification #1740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/TrayWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ public void show(@ShowFlags int aShowFlags) {

@Override
public void hide(@HideFlags int aHideFlags) {
ThreadUtils.postToUiThread(hideBookmarkNotification);
hideBookmarkNotification.run();

if (mWidgetPlacement.visible) {
mWidgetPlacement.visible = false;
Expand All @@ -294,7 +294,7 @@ public void hide(@HideFlags int aHideFlags) {

@Override
public void detachFromWindow() {
ThreadUtils.postToUiThread(hideBookmarkNotification);
hideBookmarkNotification.run();

if (mSessionStack != null) {
mSessionStack.removeSessionChangeListener(this);
Expand Down Expand Up @@ -503,8 +503,9 @@ public void run() {
public void run() {
if (mLibraryNotification != null) {
mLibraryNotification.hide(UIWidget.REMOVE_WIDGET);
mLibraryNotification = null;
mBookmarksButton.setNotificationMode(false);
}
mBookmarksButton.setNotificationMode(false);
}
};

Expand Down