This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Legacy telemetry data review.#3467
Merged
Merged
Conversation
|
The linked PR doesn't appear to be the one that added the uuid. |
700c91c to
4e8069d
Compare
Contributor
Author
Sorry for my mistake when doing copy-and-paste. The previous metric change is happened at #3384. |
|
DATA COLLECTION REVIEW RESPONSE: Yes. This collection is documented in its metrics documentation. Yes. This collection is Glean so can be controlled through Firefox Reality's Preferences. No. This collection will expire 2020-11-01. Category 1, Technical. Default on for all channels. No. Yes. Yes. Daosheng Mu is responsible for renewing or removing the collection before it expires on 2020-11-01. Result: datareview+ |
4e8069d to
8385466
Compare
8385466 to
9d14e33
Compare
keianhzo
approved these changes
Jun 12, 2020
Contributor
|
@daoshengmu This can be merged already or we have to wait for some other thing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request for data collection review form
All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
This is used for supporting legacy telemetry in the
deletion-requestping.deletion-request.Until 11/01/2020. Probably, at that time, the legacy telemetry would be no longer exist.
@chutten, please help data review. It seems like I forget to do the data review at #3324