Use try:except KeyError: instead of checking-and-returning#156
Open
akx wants to merge 1 commit into
Open
Conversation
Owner
|
Yeah I see that but we support older versions of Python and I don't want to add costs of exceptions for people using older versions of Python. I don't know if for older versions the cost will be huge or not to have exceptions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will avoid an extra dict lookup in the "misconfigured" case;
try: except:is zero-cost in Python 3.11+.These are both pretty hot paths, so a small optimization goes a long way.