Skip to content

Staging Controller improvements #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lamont-granquist merged 4 commits into from
Jul 27, 2026
Merged

Staging Controller improvements #2295

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f62e032
Small refactoring
Feb 7, 2026
1757605
Don't check if there's a fairing twice. Revert the function argument …
Feb 7, 2026
0ecb6df
Revert fairing check removal
Feb 8, 2026
0597e0f
Also fix PSG+fairing staging check
lamont-granquist Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion MechJeb2/MechJebModuleStagingController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ public override void OnFixedUpdate()
if (HasFairing(Vessel.currentStage - 1) && !WaitingForFairing())
{
Stage();
return;
}
else
{
Expand Down Expand Up @@ -319,6 +320,7 @@ public override void OnFixedUpdate()
if (!InverseStageHasActiveEngines(Vessel.currentStage))
{
Stage();
return;
}

// prevent staging when the current stage has active engines and the next stage has any engines (but not decouplers or clamps)
Expand All @@ -339,6 +341,7 @@ public override void OnFixedUpdate()
if (InverseStageDecouplesDeactivatedEngineOrTank(Vessel.currentStage - 1))
{
Stage();
return;
}

// only decouple fairings if the dynamic pressure, altitude, and aerothermal flux conditions are respected
Expand Down Expand Up @@ -478,7 +481,7 @@ private double LastNonZeroDVStageBurnTime()
private bool InverseStageHasActiveEngines(int inverseStage)
{
foreach (ModuleEngines engine in _allModuleEngines)
if (engine.part.inverseStage == inverseStage && engine.EngineHasFuel())
if (engine.part.inverseStage >= inverseStage && engine.EngineHasFuel())
return true;
return false;
}
Expand Down
Loading