Conversation
eyeseast
requested review from
allanlasser and
duckduckgrayduck
and removed request for
allanlasser
allanlasser
left a comment
allanlasser
left a comment
There was a problem hiding this comment.
Dropping some notes on backend before moving into frontend review. There's some critical decisions in migration 0060 we should discuss.
| vector = SearchVector("username", "name") | ||
| query = SearchQuery(f"{search}:*", search_type="raw") | ||
| qs = qs.annotate(search=vector).filter(search=query) | ||
| return qs |
There was a problem hiding this comment.
This is currently in our private frontend API, but this feels like a strong candidate for inclusion in the public accounts API. For our efforts to align our permissions and sharing model across products, a single endpoint for consistently searching accounts feels extemely useful. I'm going to flag this in that project as a backreference.
allanlasser
left a comment
allanlasser
left a comment
There was a problem hiding this comment.
Ok, done with frontend review. Contributing a commit with some style tweaks on the input. Going to flag this as changes requested due to comments on backend files.
Don't make everyone public yet Co-authored-by: Allan Lasser <lasser.allan@gmail.com>
…den.py Co-authored-by: Allan Lasser <lasser.allan@gmail.com>
…tion Fix migration to actually set private=False on existing individual orgs Move charge_created signal handler from users to organizations app Inline perform_create in InvitationViewSet
eyeseast
force-pushed
the
474-user-search
branch
from
110ad88 to
4adfd5c
Compare
3 participants
Closes #474
Summary
auto-unhide users on email verification or payment
GET /fe_api/users/?search=) with visibility filteringUserSelectSvelte component (Svelecte-based, supports both user searchand raw email entry) and wire it into the org invite-members form
Test plan
hidden=FalseUserSelectcomponent: search, select user, type email, remove chip