Specify in package.json bridge-pca uses ES module syntax#3
Open
Robbert wants to merge 3 commits intoMyndex:masterfrom
Open
Specify in package.json bridge-pca uses ES module syntax#3Robbert wants to merge 3 commits intoMyndex:masterfrom
Robbert wants to merge 3 commits intoMyndex:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like your other projects that already have it (
colorparsleyandapca-w3), this project should have"type": "module"specified to allow it to be used in Node.js projects with ES modules.I figured it might be convenient to update the version number already, but please let me know if I better leave it out.
By the way: thanks for all your great work on accessible colors, it has been ever so helpful!