Skip to content

OIDC Support#1746

Open
pranav-super wants to merge 38 commits into
developfrom
feature/oidc-support
Open

OIDC Support#1746
pranav-super wants to merge 38 commits into
developfrom
feature/oidc-support

test(oidc): warm up dev server before OIDC suite to de-flake first login

ff50761
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 6, 2026 in 1m 3s

Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 155 in .github/workflows/test.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Omitting "--ignore-scripts" allows lifecycle scripts to run during package installation. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ84NOIACSuz0nVHYF-_&open=AZ84NOIACSuz0nVHYF-_&pullRequest=1746

Check failure on line 79 in src/routes/oidc/callback/+page.server.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hUS2M_y02wEyUZa&open=AZ5u2hUS2M_y02wEyUZa&pullRequest=1746

Check warning on line 157 in .github/workflows/test.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define exact package version to avoid installing unverified releases. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ84NOIACSuz0nVHYF_B&open=AZ84NOIACSuz0nVHYF_B&pullRequest=1746

Check warning on line 29 in src/utilities/login.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'If' statement should not be the only statement in 'else' block 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hX32M_y02wEyUZg&open=AZ5u2hX32M_y02wEyUZg&pullRequest=1746

Check failure on line 80 in src/routes/oidc/callback/+page.server.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hUS2M_y02wEyUZb&open=AZ5u2hUS2M_y02wEyUZb&pullRequest=1746

Check failure on line 81 in src/routes/oidc/callback/+page.server.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hUS2M_y02wEyUZc&open=AZ5u2hUS2M_y02wEyUZc&pullRequest=1746

Check warning on line 10 in src/utilities/browser.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Simplify this regular expression to reduce its runtime, as it has super-linear performance due to backtracking. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ8eqNsUWgiLF8wV0b7c&open=AZ8eqNsUWgiLF8wV0b7c&pullRequest=1746

Check warning on line 124 in e2e-tests/tests/oidc.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this fixed wait with a synchronization on an observable condition. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ84NOFGCSuz0nVHYF--&open=AZ84NOFGCSuz0nVHYF--&pullRequest=1746

Check warning on line 141 in e2e-tests/fixtures/OIDC.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`cookieNames` should be a `Set`, and use `cookieNames.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hd42M_y02wEyUZ4&open=AZ5u2hd42M_y02wEyUZ4&pullRequest=1746

Check failure on line 78 in src/routes/oidc/callback/+page.server.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hUS2M_y02wEyUZZ&open=AZ5u2hUS2M_y02wEyUZZ&pullRequest=1746

Check warning on line 48 in src/lib/types/oidc.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`new Error()` is too unspecific for a type check. Use `new TypeError()` instead. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hdW2M_y02wEyUZp&open=AZ5u2hdW2M_y02wEyUZp&pullRequest=1746

Check warning on line 97 in src/hooks.server.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hdw2M_y02wEyUZ0&open=AZ5u2hdw2M_y02wEyUZ0&pullRequest=1746

Check warning on line 131 in e2e-tests/fixtures/OIDC.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`cookieNames` should be a `Set`, and use `cookieNames.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hd42M_y02wEyUZ3&open=AZ5u2hd42M_y02wEyUZ3&pullRequest=1746

Check warning on line 157 in .github/workflows/test.yml

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"npx" can install packages on-demand and run their lifecycle scripts. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ84NOIACSuz0nVHYF_A&open=AZ84NOIACSuz0nVHYF_A&pullRequest=1746

Check warning on line 49 in playwright.config.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Simplify this regular expression to reduce its runtime, as it has super-linear performance due to backtracking. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ8eqNw-WgiLF8wV0b7d&open=AZ8eqNw-WgiLF8wV0b7d&pullRequest=1746

Check failure on line 12 in src/utilities/login.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5w45b8JGkLROSmJuXm&open=AZ5w45b8JGkLROSmJuXm&pullRequest=1746

Check failure on line 82 in src/routes/oidc/callback/+page.server.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hUS2M_y02wEyUZd&open=AZ5u2hUS2M_y02wEyUZd&pullRequest=1746

Check failure on line 83 in src/routes/oidc/callback/+page.server.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of the "void" operator. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hUS2M_y02wEyUZe&open=AZ5u2hUS2M_y02wEyUZe&pullRequest=1746

Check warning on line 85 in playwright.config.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Simplify this regular expression to reduce its runtime, as it has super-linear performance due to backtracking. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ8eqNw-WgiLF8wV0b7e&open=AZ8eqNw-WgiLF8wV0b7e&pullRequest=1746

Check warning on line 108 in e2e-tests/fixtures/OIDC.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hd42M_y02wEyUZ1&open=AZ5u2hd42M_y02wEyUZ1&pullRequest=1746

Check warning on line 6 in src/lib/server/oidc.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `node:crypto` over `crypto`. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_aerie-ui&issues=AZ5u2hdO2M_y02wEyUZl&open=AZ5u2hdO2M_y02wEyUZl&pullRequest=1746
View more details on SonarQubeCloud