Add simulation dataset upload button to SimulationPanel#1970
Draft
remy-rabideau wants to merge 1 commit into
Draft
Add simulation dataset upload button to SimulationPanel#1970remy-rabideau wants to merge 1 commit into
remy-rabideau wants to merge 1 commit into
Conversation
Add upload button to SimulationPanel header with hidden file input accepting JSON files. Implement uploadSimulationDataset effect to POST simulation results via FormData to /uploadSimulationDataset endpoint with plan_id and file. Show success/failure toasts and log uploaded dataset ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REQUIRES_AERIE_PR="1852"
NASA-AMMOS/plandev#1852
REQUIRES_GATEWAY_PR="148"
NASA-AMMOS/plandev-gateway#148
Description
Adds a file upload button to the SimulationPanel that allows users to upload a simulation results JSON file (in
SimulationResultsWriterformat) and associate it with the current plan.Changes:
src/components/simulation/SimulationPanel.svelte— adds a hidden file input bound to aPanelHeaderActionButtonlabelled "Upload Simulation Results"; on file selection callseffects.uploadSimulationDatasetand clears the inputsrc/utilities/effects.ts— addsuploadSimulationDataset(plan, file, user)effect; POSTs the file as multipart form data to the gateway/uploadSimulationDatasetendpoint; shows a success or failure toastVerification
Manually tested against a running PlanDev instance. No automated tests added (consistent with existing UI test strategy for effects).
Documentation
No existing documentation covers this feature.
Future work
insert_ext_datasetpermission